bcgov / nr-theme

Common repo for FSA theme
Apache License 2.0
2 stars 0 forks source link

fix: primevue card header and content position, tag general styles #102

Closed J0taFerreira closed 11 months ago

J0taFerreira commented 11 months ago
MCatherine1994 commented 11 months ago

Let's use "fix" instead of "feat" in the pull request title, because our changes are just small changes. If we use "feat", then the release please management will bump the package version from 1.4.0 to 1.5.0, and if we use "fix", it will just bump from "1.4.0" to "1.4.1".

MCatherine1994 commented 11 months ago

let's make sure the style changes for the card works for both the user information card and forest client information card, thanks!!

J0taFerreira commented 11 months ago

Let's use "fix" instead of "feat" in the pull request title, because our changes are just small changes. If we use "feat", then the release please management will bump the package version from 1.4.0 to 1.5.0, and if we use "fix", it will just bump from "1.4.0" to "1.4.1".

got it, will do!

MCatherine1994 commented 11 months ago

Hi Jota, it might be good if you can setup the VS code formatter, so we won't always see difference for the format in the pull request. This is the setting file in FAM, I think we can use the same here.

Screen Shot 2023-09-26 at 12 06 07 PM
J0taFerreira commented 11 months ago

Hi Jota, it might be good if you can setup the VS code formatter, so we won't always see difference for the format in the pull request. This is the setting file in FAM, I think we can use the same here. Screen Shot 2023-09-26 at 12 06 07 PM

Hello! I'll make sure that my formatter matches this one. Thanks!

MCatherine1994 commented 11 months ago

thanks Jota! Let's merge from main as well, thanks!!

J0taFerreira commented 11 months ago

thanks Jota! Let's merge from main as well, thanks!! Hello, Catherine! Just solved the conflicts and the styling seens to be working fine. Many thanks!