search

bcgov / nr-theme

Common repo for FSA theme
Apache License 2.0
1 stars 0 forks source link

Can we change the url to nr-fds-theme? Or is that crazy? #64

Closed jackwingsam closed 1 year ago

jackwingsam commented 1 year ago

Can we change the url/repo name to nr-fds-theme? Or is that crazy at this point? @DerekRoberts

DerekRoberts commented 1 year ago

@jackwingsam Ha, sure! Whatever your team decides we do. :D

jackwingsam commented 1 year ago

Looks like while I was on vacation, we got approval to change from FSA to FDS

DerekRoberts commented 1 year ago

Welcome back @jackwingsam! :) ...Let's talk to @MCatherine1994 about making this change.

MCatherine1994 commented 1 year ago

Hi Jack @jackwingsam, changing repo name is doable. Just wondering since we already published some packages based on the current repo name for teams to share the stylesheet. If we change the repo name, we might want to change the package name as well?

If so please let me know when you'd like the name change to be done, thanks!

jackwingsam commented 1 year ago

i really don't know how to answer the part about the packages name.

the name change overall is not a high priority thing. but slightly higher priority now that Chantelle got the name change approved. what's a good timeline that fits your schedule?

DerekRoberts commented 1 year ago

@jackwingsam Let's leave that to @MCatherine1994. I'm mostly here for support and/or to fill in any gaps.

jackwingsam commented 1 year ago

yeah, sorry i didn't tag anyone. my last comment was meant to ask @MCatherine1994 to pick a timeline that best suits her pre-existing workload

MCatherine1994 commented 1 year ago

sure, I'll bring this to our dev meetup this Thursday cause the package naming change will impact the teams that are currently using it. And will target do the change next Monday. Thanks!

MCatherine1994 commented 1 year ago

Morning @jackwingsam @DerekRoberts, I wonder do we need to include "fds" in our repo name? Or maybe we can call it "nr-common-theme", so we don't need to worry about the team name in the future?

DerekRoberts commented 1 year ago

@MCatherine1994 I like that idea! Departments get renamed all the time in gov. Plus common says a lot. :)

Even just nr-theme works.

jackwingsam commented 1 year ago

I'm ok with a more generic name but maybe something more specific to forestry? We know there are other NR sector teams (like ENV and even with FOR/WLRS) also doing their own design systems. We tried to join forces but they didn't want to...

MCatherine1994 commented 1 year ago

how about nr-forest-theme? or any other suggestion? @jackwingsam @DerekRoberts

DerekRoberts commented 1 year ago

Ideally we'd build components that all of NR can use. Most of my tools are for general consumption, not just gov. nr-theme!

MCatherine1994 commented 1 year ago

yeah, I agree. If other teams want a different theme, they can name their repo differently

MCatherine1994 commented 1 year ago

I'll put this on hold for now until Andrea is back from the vacation and it's not that urgent, then we can discuss which name want to use.

jackwingsam commented 1 year ago

Ideally we'd build components that all of NR can use. Most of my tools are for general consumption, not just gov. nr-theme!

i like to think that way too, building for all of gov, but we did shop what we're doing with other NR teams and they were not satisfied with it.

the other thing that makes me not that comfortable with a generic nr-theme repo name is that we made a lot of decisions that are not in line with the rest of BCGov/GCPE. for example the blue that we have for the buttons across all of our login pages and headers on the content pages is not a normal BC Gov blue. we made some decisions that were only focused on FSA/FDS apps. other parts of gov may not want to follow what we did

i agree with @MCatherine1994, let's wait for Andrea

MCatherine1994 commented 1 year ago

Just to provide an update for this issue. I checked the repos in bcgov organization, don't see any other repo named with "nr" or "theme", also chatted with Andrea, we should be good to use "nr-theme". If other teams also work on other design systems, they can call their repo a different name.

I'll start to make the name change this week or next week.

jackwingsam commented 1 year ago

Thanks @MCatherine1994 @alkolot is the one who's going to have to interface with other nr design teams