search

bcgov / nr-theme

Common repo for FSA theme
Apache License 2.0
2 stars 0 forks source link

Update minimum font size in Figma to 16px and have it 1em in SCSS #81

Closed jackwingsam closed 9 months ago

jackwingsam commented 1 year ago

The proposal is to ensure that the smallest text in FDS applications is 16px (12pt font) out of Figma and that the FDS stylesheets retain relative sizing capability where 16px is equal to 1em.

This proposal originated out of a conversation between Chantelle/Andrea (Aug 21, 2023) regarding CLIENT's external form having perhaps too many levels of hierarchy (too many different font sizes). This will be addressed in a TBD ticket.

In Team Alliance's collab session (Aug 22, 2023), Ziad brought up wanting to ensure that what comes out of Figma and gets implemented in code still retains the ability for someone's browser to go bigger or smaller based on browser preferences.

In the attached screenshot from CLIENT's external application, the small helper text is currently set at 12px font (which is 16px) with 16px vertical spacing.

Image

jackwingsam commented 10 months ago

I may have made the wrong assumption about Figma using points (pt) instead of pixels (px).

It seems Figma treats points (font weight) the same as pixels. I looked at Dev mode for something that was 12pt font and it showed 12px.

Google search was inconclusive but I think we need more investigation about whether points = pixels in Figma or not

jackwingsam commented 10 months ago

Wait until Issue 83 is resolved and review again

jackwingsam commented 9 months ago

Closing this ticket. Creating a ticket specifically for updating Helper Text Size