search

bcgov / nr-theme

Common repo for FSA theme
Apache License 2.0
2 stars 0 forks source link

Landing Pages to detect theme preferences #88

Open jackwingsam opened 1 year ago

jackwingsam commented 1 year ago

Proposal: Should landing pages be responsible responsive to device theme preferences or stay in light mode only?

Background: The designers agreed to the Theme Toggle not appearing on the landing page only appearing on the blue header (as to not have to design a toggle that would also have to show up on the white and black backgrounds of the landing pages)

For Team Silva, Jazz implemented code for all of SILVA (including the landing page) to detect device theme settings. So after the Theme Toggle decision to have landing pages be light mode only, SILVA's landing page still detects device theme settings. There is no Theme Toggle on the landing so users do not have to the option to switch the theme.

We asked Chantelle if this was a problem (Sep 7 2023). Chantelle recognized this as a feature, as opposed to a problem. Chantelle wanted Team Silva to survey other teams if they want to adopt this approach for their landing pages.

jackwingsam commented 1 year ago

@jazzgrewal Do you think your device-setting-detection code is compatible with Vue? Or is it React only?

RMCampos commented 11 months ago

I believe @jazzgrewal used a CSS code. CSS is framework agnostic, but may differ on how to do it on each one of those.