bcgov / nr-theme

Common repo for FSA theme
Apache License 2.0
2 stars 0 forks source link

Change the fields' label to use "primary-text" color instead of "secondary-text" #97

Closed mgaseta closed 11 months ago

mgaseta commented 11 months ago

According to the title, we expect the labels color to be changed from secondary-text to primary-text.

This is currently listed in the change log.

As requested by Jack on issue #78, tagging @MCatherine1994 and @jazzgrewal

Jack copypasta from Figma - July 8, 2023

Enhancement: Increase text inputs’ label size and color contrast

Reason: Users found the input’s labels difficult to read and distinguish

Discussed

Resolution

What changed Labels color style

Text color will change

Components:

Themes:

Participants: Andrea Kolot Jack Sam Olga Liberchuk Michelly Marsoleta Marina Carvalho Maria Fernanda Ferreira Maria Eduarda Guimarães Sabina Donnelly

jackwingsam commented 11 months ago

@alkolot can we rush-approve this one and move it to the "Approved" backlog?

This was the item that Michelley created in July 2023 in the Figma change log (linked above).

Michelley's comment from that time was that it was already changed in the Figma library so we can skip the "in progress in Figma) column. This can go directly to the "in progress in code" once someone can take it on.

alkolot commented 11 months ago

Yes, let's move it to approved.

jackwingsam commented 11 months ago

I don't know how much work this is so can @MCatherine1994 or @jazzgrewal coordinate with @mgaseta? This was listed as a blocker for Evergreen in Issue 78

MCatherine1994 commented 11 months ago

Think once this got approved and changes have been made in Figma, then we can assign the developer in Evergreen to implement the code change as they need. @craigyu

jackwingsam commented 11 months ago

Changes should have been made in Figma already during the summer. @craigyu or @mgaseta can you please confirm with Michelley?

mgaseta commented 11 months ago

@jackwingsam Just confirmed with Michelly, it is already done on Figma.

jackwingsam commented 11 months ago

@mgaseta can you or @craigyu take on this work? if yes, do you need upgraded permissions for this repo?

mgaseta commented 11 months ago

Sure, I can take it, just need the permission.

craigyu commented 11 months ago

@MCatherine1994 can we give @mgaseta write access please?

jackwingsam commented 11 months ago

@DerekRoberts if Catherine is busy

jackwingsam commented 11 months ago

nevermind, it looks like i could have done it. just invited @mgaseta to have "write" permissions

MCatherine1994 commented 11 months ago

sorry just get this, I have the GitHub notification in another email account, maybe next time just ping me in teams, thanks!!