bcgov / nr-ticdi

TICDI Application to integrate Tantalis with CDOG

Apache License 2.0

1 stars 0 forks source link

always display admin navbar link (temporary) #164

Closed mgtennant closed 2 months ago

mgtennant commented 2 months ago

Description

Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Test A
[ ] Test B

Checklist

[ ] I have read the CONTRIBUTING doc
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have already been accepted and merged

Further comments

barrfalk commented 2 months ago

backend coverage report

Coverage after merging disable-frontend-roleguard into main will be

0.44%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
app.controller.ts	100%	100%	100%	100%
app.module.ts	0%	0%	100%	0%	1, 10–16, 18–19, 2, 21–24, 24, 24–25, 27, 3–5, 50, 6–9
app.service.ts	60%	100%	50%	66.67%	8
constants.ts	0%	100%	100%	0%	1, 11–13, 16, 18, 25, 34, 41, 49, 88
main.ts	0%	0%	0%	0%	1, 15–16, 18, 18, 18, 2, 20, 3, 6–8
ormconfig.ts	0%	0%	100%	0%	10–11, 13, 16, 16, 18, 18–19, 19, 2–3, 36, 4–9
util.ts	0%	0%	0%	0%	1, 10, 110, 126, 126–127, 129, 133, 135, 148, 150–151, 151, 151–153, 153, 153, 153, 153–155, 155, 155–156, 159–160, 160–161, 163, 163–164, 166, 166–167, 169, 171–172, 172–173, 173–174, 174–175, 177, 179, 179, 179–180, 180, 180–182, 184, 186, 186–187, 187, 187–189, 191, 196–199, 2, 202–205, 208, 214, 250–260, 262, 262–264, 264, 264–267, 267–270, 270, 270–272, 272, 272–273, 273–275, 275, 275–278, 278, 278–280, 280, 280, 285, 285–286, 288, 288–289, 292, 292–293, 295, 295–296, 299, 299–300, 302, 302–303, 306, 306–307, 310, 310–314, 314, 317, 317–318, 320, 320–321, 323, 323–324, 326, 326–327, 330, 346–347, 347–348, 35, 350, 350–351, 353, 353–354, 356, 358, 36, 362, 362, 362, 362, 362, 374, 38, 387, 389–390, 393–394, 397, 399, 40, 402–404, 404, 404, 404–405, 407, 407, 407, 407–408, 410, 410, 410, 410–411, 413, 416, 42–43, 43, 43, 431–432, 434, 436, 436, 436–437, 439, 44, 442–443, 445, 445–446, 45, 45, 45, 45, 45, 450, 454, 459, 46, 460, 460, 460, 460, 460–461, 464, 467, 47, 47, 47, 470, 475, 48, 481, 481, 481, 487–488, 488, 488, 488, 488, 488–489, 489, 489–490, 490, 490–491, 491, 491–492, 494, 498–499, 499, 499, 499, 499, 5, 500, 500, 500–501, 501, 501–502, 502, 502–503, 505, 508–509, 51, 510, 510–511, 511–512, 515, 515–516, 519, 519, 52, 52, 520, 524, 527–528, 528, 528, 528–529, 53, 531, 534–535, 535, 535, 535, 535–537, 537, 537, 537, 537, 537–538, 540, 55, 55–56, 58, 58–59, 6, 61, 63–64, 64–65, 65–66, 66–67, 69, 7, 7, 7, 71, 71, 71–73, 75, 79, 8, 80–82, 85
src/account
account.filter.ts	0%	0%	0%	0%	1, 10, 10, 10–13, 2, 5, 7–9
account.guard.ts	0%	0%	0%	0%	1, 11, 5, 7–8, 8, 8–9
account.module.ts	0%	100%	100%	0%	1, 11, 2–4
src/admin
admin.controller.ts	0%	0%	0%	0%	1, 100–106, 110, 114–115, 120, 139, 139, 139, 139, 139, 141, 141, 141, 141, 141, 141–142, 150–151, 158, 160, 163, 165, 169–172, 174, 179, 188–189, 19, 190, 192, 196, 198, 201, 203, 206, 208, 211, 213, 216, 218, 221, 223, 226, 228, 23, 231, 233, 25–26, 28, 40–42, 42, 42–43, 43, 43–45, 53, 58, 66, 73, 82–87, 92, 94–95
admin.guard.ts	0%	0%	0%	0%	1, 11, 11, 11, 11, 11–13, 13–14, 17, 5, 9
admin.module.ts	0%	100%	100%	0%	1, 10–13, 2, 21, 4–6, 8–9
admin.service.ts	0%	0%	0%	0%	1, 107–109, 11, 114, 117–118, 120, 120, 120–121, 121, 121–122, 122, 122–123, 123, 127, 127, 127–128, 128, 13, 132, 138–139, 144, 147–148, 150–152, 152, 152, 152–153, 156, 156–157, 159, 172–175, 18, 180, 182–183, 183, 183–185, 185–186, 188–189, 2, 20, 200, 203–204, 206, 21, 215–217, 22, 222, 224, 226, 23, 230–232, 237–238, 24, 240, 242, 252–255, 26, 26, 26, 260, 263–264, 266, 270–273, 28, 28, 28, 284, 288, 292, 296, 3, 300, 306, 310, 312, 314, 316–317, 32, 326–328, 328, 328–329, 329, 329–330, 330, 330–331, 331, 331–332, 332, 332–333, 340, 343, 351–353, 353, 353–354, 354, 354–355, 355, 355–356, 356, 356–357, 357, 357–358, 358, 358–359, 359, 359, 36, 361, 364, 368–369, 371–373, 390, 40, 400–402, barrfalk commented 2 months ago Your Pull Request code is being promoted! Please follow the link below. Main Merge Workflow © Githubissues. Githubissues is a development platform for aggregating issues.