search

bcgov / nr-vdyp

Variable Density Yield Projection
Apache License 2.0
0 stars 4 forks source link

Monorepo #52

Closed smithkm closed 4 months ago

smithkm commented 4 months ago

Replaces #50

Merge after #47.

smithkm commented 4 months ago

The duplication Sonar is reporting is in code that was already in the repo but has moved. I've tried to eliminate it but a lot of it seems to be not completely duplicate so much as a repeating pattern with different values. I can't see a good way to make sonar happy with those sections without making the code less readable. I can't see any way to tell Sonar to ignore the duplication other than to select the "Merge without waiting for requirements to be met (bypass branch protections) " option on the PR.

sonarcloud[bot] commented 4 months ago

Quality Gate Failed Quality Gate failed

Failed conditions
4.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud