bcgov / nr-vdyp

Variable Density Yield Projection
Apache License 2.0
0 stars 4 forks source link

Add API Client Library and Integrate VDYP Frontend with the Library #79

Closed vividroyjeong closed 5 days ago

vividroyjeong commented 2 weeks ago
vividroyjeong commented 2 weeks ago

@dhlevi Thank you so much for the good suggestion, I will rename that file to vdyp-api.

Also, I called the API folder 'file-api', in fact, I was thinking of changing it to 'projection-api' because it's not very clear, is that okay? I'm thinking of renaming it that way for extensibility because I thought there might be other API client libraries in the future. However, I am not sure about that. If no other client libraries are added, I guess we could just call it 'api' or 'vdyp-api'. Any advice would be appreciated.

I don't think the naming "Default-api" makes sense, so we'll want to change this to be more specific to "vdyp" unless we're expecting to have multiple clients that may require a default?

vividroyjeong commented 2 weeks ago

@dhlevi after the code review, there were additional other changes as well as file name change. I've changed the comment at the top of this PR screen to include the changes, and I've also changed the PR title. Please review this PR again. Thanks!

vividroyjeong commented 1 week ago

@dhlevi please review this PR I couldn't merge with the main branch after the previous review because there were issues in the backend at the time, and the backend issues were recently fixed. This is because I was asked not to merge with main if there was an error under PR validation. So the changes since the previous review have been added to this PR, and I apologize for any unintentional inconvenience to your review. As you suggested last time, I wanted to avoid too many review requests at once, but this time it was unintentionally merged with this PR.

The main changes are listed below:

sonarcloud[bot] commented 6 days ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud