bcgov / nr_fsa_fingerprint

This repo is not for a specific project, but as a holder for the Forest Service Applications work by FSA team 2 (fingerprint)
Apache License 2.0
1 stars 0 forks source link

Automatically public the notice on an "extra "notices" tab on FOM platform #42

Closed gormless87 closed 2 years ago

gormless87 commented 2 years ago

. In order to facilitate the publishing of the initial notice on a government website, we need to add a tab/screen to the software. The idea is for FSP holders to fill out a form that contains all legally required notice content ( i.e. Company, contacts, place of business, business hours etc.). Once the form has been completed, a “prefabricated” official notice should be published on the new notices tab/page every time a FOM of the respective user opens for commenting ( switches from publish to commenting open).

This issue transferred from Jira (FOM-111)

image-2022-03-07-10-59-28-245.png screenshot-1.png screenshot-2.png screenshot-3.png

gormless87 commented 2 years ago

BVANDEGRVandegriend, Basil IIT:EX added a comment - 14/Mar/22 12:18 PM - edited Feedback from mockup review session: Public Front-End:

Remove FOM ID from Public Notice Summaries Add District to Public Notice Summaries (just before Commenting Open Date) Rename field labels to be clearer: "Review FOM Address" -> Address to Review FOM, similar changes for other fields If "receive comments same as review" flag is true, do the following: Don't show the 2nd set of receive comment fields Change the label for the first set of fields to be "Address to Review FOM and Receive Comments" Add lines between public notice rows when not expanded, especially on mobile view When public notice rows are expanded, there are two lines shown between each row, should be just one. Desktop view for expanded public notice has too big a gap between field labels and field values, for both the two column section and the one column section. Nice to haves (leave to end if have budget): Add header to public notice summaries (maybe only for non-mobile view, still needs to work in mobile view) Add ability to filter by various fields like district, FOM Holder, directly on the Public Notice screen Add an indicator onto each row showing whether it is expanded or collapsed (e.g. triangle) Admin Front-End:

On the Edit FOM screen, rename 'Initial Public Notice' to 'Newspaper Public Notice' Rename the "Edit Public Notice" to "Edit Online Public Notice". On Edit Public Notice screen, rename field labels to be clearer (as listed for Public front-end) On Edit Public Notice screen, if "receive comments same as review" flag is true, disable the 2nd set of address/business hour fields. On the Edit Public Notice screen and Edit FOM screen, can we display the FOM id in the title - e.g. Edit Online Public Notice #1234 Add a delete button on the Edit Online Public Notice screen. This will delete the entire record and cause it to not be displayed Add an indicator on the View FOM screen whether the online public notice exists When creating a public notice for a FOM, load defaults from the last updated public notice for the same Forest Client. Nice to Haves On Edit Public Notice screen show example text for the address & business hour fields.

gormless87 commented 2 years ago

AMBUJOLDBujold, Anne-Marie IIT:EX added a comment - 21/Mar/22 11:19 AM - edited Headers for company name, FOM holder, District, commenting open date on the public notice screen on the public side. Possible to put when collapsed but not expand if not too difficult.

Change labels for Address to Review FOM and Receive Comments to be Physical address instead. See attached images.

gormless87 commented 2 years ago

BVANDEGRVandegriend, Basil IIT:EX added a comment - 06/Apr/22 1:55 PM Review feedback:

Admin site:

Validations for all fields all show up after leaving any field on a new public notice Validation of address has two validations - required and not empty, should just be one validation warning for this Default text for address fields is darker, should be ligher Wording of default text for addresses should be changed, Anne-Marie to provide wording Field "Email" should be called "Email for Public Comment".

Public site:

list the statement regarding "validity period" (on bottom of details screen) on bottom of public notice screen Field "Email" should be called "Email for Public Comment", moved to bottom Filtering options still to be added Basil still needs to review how it looks with multiple public notices

Code base:

Have more test data, at least three public notices Fix isUpdateAuthorized (and maybe other security checks) Caching needs to be fixed to be same as other public front-end data - 24+ hour expiry, loaded at startup, refreshed by batch process. (Basil can help explain/do this if necessary.) Basil still needs to do a more detailed code review.

gormless87 commented 2 years ago

This issue was in-progress when copied from Jira (FOM-111). Work will be recorded in Jira, closing FOM backlog items issue.

gormless87 commented 2 years ago

This issue was in-progress when copied from Jira (FOM-111). Work will be recorded in Jira, closing FOM backlog items issue.