bcgov / ols-geocoder

Physical Address Geocoder
Apache License 2.0
10 stars 6 forks source link

Make site ids immutable in data prep #29

Open mraross opened 5 years ago

mraross commented 5 years ago

Problem Currently, site ids are mutable; they are different every time an address data integration is performed (e.g., currently monthly). If an application makes a geocoder request, hangs on to the site id for dayw or weeks, then uses the id in another geocoder api request such sites/{siteID}/subsites, the id will likely be invalid by then. This problem will become more apparent if and when we start more frequent data integrations.

Proposed solution Copy fullAddress into siteID; it is unique and quite stable. For example, 1175 Douglas St, Victoria, BC doesn't change much from decade to decade.

alixcote commented 1 year ago

Check data prep document. Who is storing siteid to use later? What is the effort to use an address instead of a hash? DataBC to investigate further.