bcgov / ols-geocoder

Physical Address Geocoder
Apache License 2.0
10 stars 6 forks source link

Locality Names do not include punctuation from GNIS #365

Closed cmhodgson closed 10 months ago

cmhodgson commented 11 months ago

The new Java based data processing pipeline is not outputting the "more correct" version of locality names from GNIS.

gleeming commented 10 months ago

Earlier today I posted a Jira ticket for GeoBC with the 9 community names in BCGNIS that are similar to ITN locality names but with punctuation or case differences. Interestingly there are 4 ITN localities with dash characters, but that was the only non-letter character currently used.

cmhodgson commented 10 months ago

PR #358 was the fix for this issue, PR #366 now supports both the old and new column names as this seems to be a recurring problem.

cmhodgson commented 10 months ago

Brad I will let you close this if you are happy that this is resolved.

brad-sparks-gov-bc-ca commented 10 months ago

Chris - this Java update worked great, tested both versions of the BCGNIS file, I will close this ticket, and also let Mike deal with the PR 366.