bcgov / ols-router

BC Advanced Route Planner
https://bcgov.github.io/ols-router/
Apache License 2.0
23 stars 11 forks source link

Add "enable" parameter as an alternative to disable #200

Closed cmhodgson closed 3 years ago

cmhodgson commented 4 years ago

The operation and name of the "disable" parameter was chosen because it was expected that the list of functions to disable would be shorter than the list of functions to enable; however, if new (potentially experimental) functions are added to the router in the future, clients using a hard-coded list of disable features would have the features enabled unintentionally, which could have undesirable side effects. Perhaps the disable parameter should even be deprecated due to this.

If we allow for either or both parameters, we need to consider the precedence; to disables override enables, or vice versa? My feeling right now is that we should actually deprecate disable altogether, and ignore it if an enable is provided; only if a disable is provided and no enable should we maintain the current behaviour.

mraross commented 4 years ago

Need to add ldf (local distortion field) and gdf (global distortion field) to the list of options that can be enabled

cmhodgson commented 4 years ago

This is done and deployed. ldf/gdf will be added with their respective tickets.

mraross commented 4 years ago

Verified in delivery