bcgov / ols-router

BC Advanced Route Planner
https://bcgov.github.io/ols-router/
Apache License 2.0
23 stars 11 forks source link

make MAX_SNAP_DISTANCE a query time parameter #332

Closed dkelsey closed 1 year ago

dkelsey commented 2 years ago

Is your feature request related to a problem? Please describe.

Routing challenges in the Peace River region:

The parties involved have scripted "work arounds" which they can continue to do, however, the workaround add complexity.

Describe the solution you'd like

There is no query time parameter which can set the tolerance distance for a route query. A query time parameter would simplify, potentially, finding routes when the starting point is more than the current snap-to tolerance (1km)

Describe alternatives you've considered

The client does have work around and can continue to do this however this adds complexity. We are exploring whether changing the tolerance can work.

Additional context

dkelsey commented 2 years ago

LOC-2635

cmhodgson commented 2 years ago

Adding a query-time parameter for the tolerance would not be hard to do, there would be more work in testing and deployment than in the change itself.

It would be interesting to know what their work-around is and if it also suffers from the issues that we expect if we increase the snap tolerance, eg. the nearest routable road segment is not necessarily the most accessible via existing resource roads.

Maybe there are some "major" resource roads that should be add to the routing network for truck queries and/or when a new "allow resource roads" parameter is turned on. We know there are too many resource roads to include them all, and they are of unknown accessibility and accuracy. Perhaps when the source or destination point is nearest to a major resource road then the they could be allowed automagically? They probably shouldn't be allowed in the middle of a route, only at either end. But that is all based on identifying some subset of resource roads that are significant, current, and accurate, and adding them to the routing network. Maybe there are just a relatively small number of particular, active mines or other sites that need their access roads added?

BK01 commented 1 year ago

Duplicate issue. Snap tolerance parameter covered in (#356). Adding a small subset of non-demographic roads will be covered in a separate issue.