search

bcgov / orgbook-bc-client-angular

Angular application for OrgBook BC
Apache License 2.0
0 stars 5 forks source link

Column sorting in credentials timeline panel is not working #22

Closed alexgmetcalf closed 2 years ago

alexgmetcalf commented 3 years ago

On a credential detail page, if you switch the timeline view of credentials at the bottom of the page from date view to list view, then clicking on any of the headings to sort by other criteria doesn’t work, and instead links back to the homepage.

image
alexgmetcalf commented 3 years ago

Example page to reproduce: https://www.orgbook.gov.bc.ca/en/organization/registration.registries.ca/BC1101218 (Production OrgBook BC)

amanji commented 3 years ago

After looking at the code, it appears this feature is not even implemented. The bolding and down arrow suggest that active sorting is available and applied, however this is hard coded into the HTML (i.e it is just styling applied to the interface). Furthermore, based on the sorting criteria, the dates should be shown in descending order, but they are displayed in order of the credential effective date (default). With proposed changes to OrgBook UX, wondering if we want to move forward to complete this implementation or do we want to hold off until the proposed UX changes are established.

I will let @swcurran weigh in.

swcurran commented 3 years ago

I'd say hold off.

amanji commented 3 years ago

Should I just remove the styling and convert those to standard text headers so users aren't confused?

swcurran commented 3 years ago

Assuming trivial - go ahead, but we don't want to do much on this, even if it looks bad.

amanji commented 3 years ago

Will be fixed as part of the UI re-write.