search

bcgov / orgbook-bc-client

Vue.js rewrite of OrgBook BC
Apache License 2.0
6 stars 8 forks source link

added search help popup #141

Closed wadeking98 closed 2 years ago

wadeking98 commented 2 years ago

Added UI components and functionality to instruct users on how to search. Here are the mobile and desktop views for the UI.

Desktop:

image

Mobile:

image

The popup uses the wording in #140

Signed-off-by: wadeking98 wkingnumber2@gmail.com

swcurran commented 2 years ago

What is the status of getting the UI changes you have done to production? What is the flow for those happening?

wadeking98 commented 2 years ago

@swcurran I believe once all the priority issues are cleared, Wade Barnes will create a new release and deploy it to test. After all the testing is completed in test, it will be moved to prod

WadeBarnes commented 2 years ago

Correct, I was waiting for the rest of these to be knocked off first; https://github.com/bcgov/orgbook-bc-client/issues?q=is%3Aissue+is%3Aopen+label%3A%22priority+for+cleanup%22

swcurran commented 2 years ago

How much extra work is it to push them as they are completed? I was expecting/would prefer them to go as they were done. Not the end of the world, but all things being equal, the sooner the better.

WadeBarnes commented 2 years ago

I'll push what we have to test. Someone should go through each issue and give it a good test.

wadeking98 commented 2 years ago

issue #113 is waiting on the meeting with the GDX folks issue #74 is waiting on Dwayne Gordon to get the wording in place issue #76 is waiting on this PR to be reviewed and merged: https://github.com/bcgov/orgbook-bc-client/pull/139

WadeBarnes commented 2 years ago

@swcurran, The latest code is now in test.

swcurran commented 2 years ago

Testing. A link on the results page should also be there to the same text. It should be beside the "xxx result(s)" line.

image

Try to see of you can make "Not finding what you want?" look good, or just use the same "(I)" icon as on the main page.