bcgov / orgbook-bc-client

Vue.js rewrite of OrgBook BC
Apache License 2.0
6 stars 8 forks source link

Link to issuing Authority not working #160

Closed WadeBarnes closed 2 years ago

WadeBarnes commented 2 years ago

Example corp: https://orgbook.gov.bc.ca/entity/BC0432724

In the credential history scroll down to the Buy BC Logo Licensee and open it up. image

Click on the Investment Agriculture Foundation BC link.

Expected behavior:

Actual Behavior:

WadeBarnes commented 2 years ago

This issue seems to affect the issuing Authority links of any credentials that is not associated to the BC Corporate Registry, so all credentials from:

WadeBarnes commented 2 years ago

This is due to the fact the issuers, other than BC Corporate Registry have not registered a URL that would be used for this link. The issuer registrations can be found here; https://orgbook.gov.bc.ca/api/v2/issuer.

The default in this case is to have the issuing Authority link link back to the corporation to which the credential was issued.

WadeBarnes commented 2 years ago

This default behavior is a little confusing. I'm wondering if it would be better for the link to go to a generic Issuing Authority page that displays the registration information (and logo if one is registered) for the issuer. In all cases there is an email address registered for the issuers, but that information is inaccessible through the current UI.

WadeBarnes commented 2 years ago

@swcurran, Thoughts?

swcurran commented 2 years ago

First, I would encourage us to go back to the issuers and get the URLs and add them in. @DJ-Gordon -- is that something you can do? I assume once we have them, we can add them easily to the database?

That said, what do we do if we don't have them?

I'd suggest one of two behaviours:

I don't think it worth adding another page specifically for this situation as it encourages bad behaviour by the issuers -- not supplying the needed info.

Personally, I think I would go with no link.