search

bcgov / parks-adventure-mobile

BC Parks Adventure Mobile
Apache License 2.0
3 stars 3 forks source link

Carousel card banner #29

Closed chadfawcett closed 3 years ago

chadfawcett commented 3 years ago

123461314_412160799782259_4579704183556331763_n 123371100_641780999846310_1998343681678962464_n 123626714_1541828756004023_5554854219777759106_n 123959097_400142941370927_2197125136664011699_n

Resolves pe1539

chadfawcett commented 3 years ago

@mccullochk

  1. Looking at the design it seemed like they were showing the headline when there was only one alert, so that's what I went with. (Examples were "Rushing water conditions" and "Park closed". I'd personally be okay with either, was just trying to follow the designs as I assumed that's what has been approved.

  2. I took a look at your PR to try to see what you had done there, but that portion wasn't committed (from what I could tell at least). My thinking was between having the advisories actually attached to the park or just their ID (like the facilities and activities). I hadn't thought about separating between alerts and advisories. I think my intuition would be to leave them together, as that's how the data is, but I can also see the benefits of separating them.

mccullochk commented 3 years ago

@chadfawcett, yeah I did not include it in the AlertAccordion PR. It will/would be part of the Park Details page PR. Let's leave these things as they are and I can circle back on the first point with Lindsey in Clubhouse or Slack so that we can get this merged in before you leave 🙂

chadfawcett commented 3 years ago

Thanks @mccullochk