[M] Sites Implementations - API - Site Object GET

[danieltruong]

Implementation ticket for ticket #332

Blocks ticket #395

AC:

• Facilitates getting of a list of site objects (PK is {ORCs}::Site::{siteId})
  • Endpoint path should be /sites /_identifier GET
  • You can filter via sk and/or status
  • Biz rule: If a park is pending, public users should not be able to get its associated site objects.
• Postman is updated
• Unit tests are updated
• SAM template is updated

[manuji]

Tested on Test: Passed

• Verified that the API end point works as expected.
• Passing to PO review.

Few things I noticed when testing are below;

• Similar to https://github.com/bcgov/parks-data-register/issues/404, it's not clear what to expect when the Park is in "Pending"status.
• When provided with invalid arguments, the returned response doesn't really explain much to the user.

eg: There is no site with the id=4 in Orc=6648, I was expecting a 404 instead of a 200 OK

[manuji]

During the stand-up today, @mark and @cameronpettit confirmed that we are not focusing on features related to "Pending" status and that can be ignored. FYI @JLWade @Dianadec

[cameronpettit]

@manuji the 200 OK response just means the API didn't run into any errors when looking for your query. It 'found' the route you asked for, it just happens that route returns an empty list. I'm not sure about the use of 404 NOT FOUND in cases like this, I think it needs to be part of a larger discussion for API queries.

We should, however look at implementing a front end 404 page, though it is unrelated to this ticket.

[manuji]

Thanks @cameronpettit for the reply.

[JLWade]

moving to done