bcgov / parks-reso-admin

Day Use Pass
Apache License 2.0
4 stars 13 forks source link

BRS-1089 & BRS-1017: updates to pass list #274

Closed cameronpettit closed 1 year ago

cameronpettit commented 1 year ago

Jira Ticket:

BRS-1089/BRS-1017

Jira Ticket URL:

https://bcparksdigital.atlassian.net/browse/BRS-1089 https://bcparksdigital.atlassian.net/browse/BRS-1017

Description:

This change introduces new visual updates to the Pass Management section of the site, now located on its own route. The updates include:

A couple of points:

  1. The new accordions are complex and, on slower browsers, may slow down pages with many results ( >1000, for example, if you don't filter by a date).
  2. The responsive design does not include html table elements (tr, td, tbody, etc).
  3. The checkedIn filters are applied after the api returns a list of passes. Ideally this would be handled in the API, but based on the designs it appears that this filter is intended to be used after the other filters have been applied and a pass list is returned.
  4. The global dataService was slightly modified to improve the functionality of the lesser-used appendItemValue and mergeItemValue: effectively, if an item in the data store was defined but had no value (null or undefined), then that item/value could not be concatenated or merged with.
  5. On loading the pass list page with query params in the URL, the page is supposed to autosearch if the correct params are available. A race condition was fixed where the params would fail to search because the autofetched parks and facilities had not been loaded in yet.