Open kgorana opened 11 months ago
Jessica Wade August 9, 2023 at 12:30 PM
Going to move this one back into backlog for now for remaining issue.
Manuji Samara August 8, 2023 at 3:59 PM
Thanks a lot @Jessica Wade .
Jessica Wade August 8, 2023 at 3:58 PM
much more consistent - and doesnt revert to garibaldi park! Only think remaining is that load more button piece you have outlined below @Manuji Samara .
Jessica Wade August 8, 2023 at 3:41 PM
for sure
Manuji Samara August 8, 2023 at 3:39 PM
Yeah it seems to be consistent. I really appreciate if you can check that as well @Jessica Wade because that behavior was intermittent .
Jessica Wade August 8, 2023 at 3:36 PM
Thanks @Manuji Samara ! Is the filtering issue resolved? (Ac bcgov/parks-reso-public#1)
Manuji Samara August 8, 2023 at 12:58 PM
Tested on TEST: Pending
The Load more button is still displayed along with the “No passes to display” user message, to replicate this issue select just the park, facility, and pass type leaving the date filter empty.
@Mark Lisé & @Jessica Wade FYI
Manuji Samara July 14, 2023 at 11:47 AM
@Jessica Wade please feel free to add a comment with your input as well.
After some investigation, the issue here is that we are doing a scan of dynamo, and there are specific limits in place to prevent dynamo from running off and executing too many capacity units. It is running the query, and then stopping as it cruises through 1000's of passes (because it's not hitting the date index) which hits it's limit of scanning up to a maximum of 1MB
of data at a time. Sometimes it will return a result when you hit load more, sometimes one or more. It ultimately depends on what it finds in the 1MB scan operation.
So - not exactly a bug - but the nature of what we have. We will want to look at deploying an opensearch instance like in the data-register. This way the search will perform much better and will fix/enable a bunch of things that previously hasn't been possible with the current search. This would also fix the issues happening in #305
@JLWade This ticket is ready to be brought in for team refinement.
deleting from project.
How to replicate:
Pass search
Load more
option a few times.Expected Behavior:
Load more
button should not be displayed.Issues:
Load more
is displayed, when that button is clicked a few times, it starts to show records one by one.Linked Issues:
305
Note
See comment https://github.com/bcgov/parks-reso-admin/issues/306#issuecomment-1901029536 for more fine grained problem and solution for this and #305