[S] Issue with the PM pass check-in window.

bcgov / parks-reso-admin

Day Use Pass

Apache License 2.0

4 stars 13 forks source link

[S] Issue with the PM pass check-in window. #324

Open manuji opened 9 months ago

manuji commented 9 months ago

Scenario:

Navigate to the DUP public site on test environment
Book a PM pass for the current day.
Now navigate to the DUP Admin and login as an Admin user at 12pm or before 1pm.
Pull up the pass from the Pass Management and see how it is displayed

Expected:

The PM passes should show as "Pass Active" after 12 pm on the day the pass has booked for.

Issue:

When a PM pass is checked on Pass Management after 12 pm before 1 pm to check-in, the pass is labeled as "Pass Reserved", instead of "Pass Active". But the option to "Check-in is enabled.

Refer to the screenshot:

screencapture-d3jkh5unv9de6y-cloudfront-net-dayuse-pass-management-check-in-2023-11-23-12_20_40.pdf

marklise commented 9 months ago

@manuji can you use PNG's for screenshots so that a) it can render inline the page and b) we don't have to download a PDF and then open it in another app. Thx!

marklise commented 9 months ago

@manuji what time exactly did you reserve the pass from public side?

JLWade commented 9 months ago

@Christopher-walsh22 are you meaning to assign this one to me?

Christopher-walsh22 commented 9 months ago

No, I was waiting for stand up to ask if you re-assigned from me to you. I must've misclicked when I originally brought it in. Sorry!

manuji commented 9 months ago

Hi @marklise, I booked the pass at 12:19pm.

Christopher-walsh22 commented 9 months ago

I had a quick discussion with @manuji this morning as I have been having troubles recreating locally; and finding the flaw in the logic that is preventing these reservations from changing to active after the activation time. We came up with a plan to test this further and will discuss afterwards with the results.

Christopher-walsh22 commented 9 months ago

I have created a PR to address this issue: If a user was to make a reservation between the window of 12pm-1pm it would be created as reserved and not active. I have let @manuji know. The additional testing we spoke about this morning will also identify if there is any other problems.

manuji commented 9 months ago

Hi @Christopher-walsh22 , as per our discussion I re-tested and verified, if the user has booked the PM pass prior to 12pm, then this issue does not happen. If the PM pass is booked after 12pm for the current date, then the pass shows as reserved. I will check back after 1 pm to see if it continues after 1 pm.

manuji commented 9 months ago

Tested on TEST: Passed

Verified that this issue has been fixed.
Passing this to PO review.

JLWade commented 8 months ago

moving to done