[L] SMS Reminders in DUP - API

kgorana commented 1 year ago

Description

As a park visitor, I would like to get a convenient reminder of my Day Pass reservation via sms so that I can easily cancel or remind myself to show up. This is in addition or alternative to email reminder - user preference as many people would prefer a reminder via sms.

This was recommended by the behavioral insights group as a way to reduce no shows.

This ticket is to specifically set up GC notify to send reminder text message to those who have opted in. The opt in front end on DUP public is covered in #288 and related to this ticket.

Acceptance Criteria

reminder SMS goes out at 4pm the day before (similar time to the email reminder)
reminder SMS only goes to those who supplied a phone number and opted in
If user cancels reservation before booking, they do not receive a text message notification
Text in reminder SMS: Hello ((NAME))

This is a reminder that you have reserved a [am, pm, or all-day] day-use pass tomorrow for Garibaldi Provincial Park - Cheakamus. If you do not intend to use your pass, please cancel using the following link to allow someone else to reserve the pass.
((Cancelation Link ))

user can click cancellation link in txt to cancel their specific reservation (via current cancellation process)

Notes

relates to #288 https://github.com/bcgov/parks-reso-admin/issues/323 https://github.com/bcgov/parks-reso-api/issues/329
Chris to connect with Manuji and add her cell phone number to TEST for testing

MarshallHenson commented 11 months ago

@JLWade I spoke with Nicole and we finalized some copy for both the reservation page and the text message. She is going to pass them along to Chris

manuji commented 11 months ago

Merging this PR to the Main branch is blocked by the pending PROD deployment. I will let @Christopher-walsh22 know when things are all sorted and ready for new code merging.

FYI @ashley-dhillon

Christopher-walsh22 commented 11 months ago

@manuji has confirmed the environment is clear and this is ready to be merged. I have also updated the environments (Dev + Test+ Prod) with the needed parameters for using gc notify sms features.

manuji commented 11 months ago

Tested on TEST: Failed

As a user who had a pass for the next day did not get the SMS at 4 pm.

Christopher-walsh22 commented 11 months ago

Found the issue and fixed with a new PR.

manuji commented 11 months ago

Tested on TEST: Pending

verified that the SMS is received at 4 pm the day before the visit if the phone number is provided and if the pass has not been canceled.
There is a small issue with the SMS format below; the pass type (am, pm, all-day) should be displayed in lower case and "DAY" should be displayed as "all-day".
Also, the sentence starts with "if..." should be started in a new line.

Please ignore the name in the text as I have put the name to identify different scenarios.

Christopher-walsh22 commented 11 months ago

@manuji I have updated the template in GCNotify and have a PR code-review addressing these issues :)

manuji commented 11 months ago

Tested on TEST: Passed

Everything looks good but when we have the "am" and "all-day" passes, we need to use the appropriate "indefinite article". eg: if it's "am", it should be an am day-use pass. @JLWade & @ndelraye , what are your thoughts? I checked the email format and it doesn't use the proper indefinite article as well.
passing this to PO reveiw.

JLWade commented 11 months ago

@Christopher-walsh22 can you add estimated story points to this one

JLWade commented 11 months ago

Good catch @manuji I think we should resolve but not urgent - can you make a new ticket for that an am (to replace a am) and also to capitalize AM and PM? add it to the backlog assigned to me and I can move it into a future sprint.

JLWade commented 11 months ago

Moving this one to done

manuji commented 11 months ago

@JLWade here is the ticket: https://github.com/bcgov/parks-reso-public/issues/299

bcgov / parks-reso-public