[S] Update booking times for summer schedule in DUP

bcgov / parks-reso-public

Day Use Pass Public

Apache License 2.0

4 stars 17 forks source link

[S] Update booking times for summer schedule in DUP #359

Closed JLWade closed 5 months ago

JLWade commented 5 months ago

Text on booking page in DUP public need to be changed for AM and PM from 12pm to 1pm.

Change AM to: 7am - 1pm (depart by 1pm)

Change PM to: Arrive after 1pm

change text on the booking page here:

Acceptance Criteria

12pm is changed to 1pm on booking page
backend logic reflects 1pm as well
- this affects what time passes transition from active to expired status

Notes

similar to: https://github.com/bcgov/parks-reso-public/pull/210 from last year and reverse of https://github.com/bcgov/parks-reso-public/issues/280

manuji commented 5 months ago

Tested on TEST: Pending

Verified that the FE updates have been done and copy shows 1pm instead of 12pm.
Verified that the AM passes expire at 1pm now instead of 12 PM.

Issue: @cameronpettit , for PM passes, I was able to check-in before 1 pm for a PM pass; could you please check if we have set the logic for this correctly on Admin ? If you check the image given below; for a Sub area in Mount Seymour, I have booked a PM pass and I was able to check-in few minutes before 1 pm. Is this something intentional or error? Please let me know.

FYI @JLWade

cameronpettit commented 5 months ago

I'm actually not sure about this one. I think we had it set up so that you could check in passes before the slot opened (that would make things simpler for the park operators). I took a quick look at the check in code and I cant see anywhere it verifies the time of check-in. @danieltruong may be able to jog my memory on this.

manuji commented 5 months ago

During the stand-up it was confirmed that it's the expected behaviour. Passing to PO review.

JLWade commented 5 months ago

looks good - moving to done