bcgov / performance

Performance
Apache License 2.0
0 stars 2 forks source link

Employee Profile Sharing Dropdown List Delay #1337

Closed telusdcinco closed 1 month ago

telusdcinco commented 1 month ago

It's been noticed that the dropdown list for sharing employees in My Team's Employee Profile Sharing modal page, is taking too long to return values. This part of the application have remained almost the same for the past 2 years, and can be updated to improve the performance by applying the changes below.

jessicahjwu commented 1 month ago

Related to #1304

telusdcinco commented 1 month ago

MIGRATION NOTES:

Code change only.

telusdcinco commented 1 month ago

@jessicahjwu @steffipravasi

The fix works very well and the dropdown is very responsive.

Should we change the behavior of the dropdown to not display anything when the user have not entered a single letter, so that the dropdown do not display same default full list as shown below?

image.png
telusdcinco commented 1 month ago

Fixed the format issue for the missing email address.

Also updated the name to use the Employee Demo name and not the User Profile name.

image.png
steffipravasi commented 1 month ago

@telusdcinco 1) The shared with list again won't load in my current goals

Screenshot 2024-07-25 at 10.11.46 AM.png
telusdcinco commented 1 month ago

@steffipravasi This ticket is for the My Teams page issue. I think the My Goal is a different ticket.

steffipravasi commented 1 month ago

The list in my goal is also loading now

Screenshot 2024-07-25 at 11.27.26 AM.png
telusdcinco commented 1 month ago

@jessicahjwu @steffipravasi Updated the dropdown search to allow searching from both employee demo or user profile names. User can now search using "John Smith" or "Smith,John" formats.

telusdcinco commented 1 month ago

@jessicahjwu There is significant performance degradation on the dropdown by searching in 2 name formats. Recommend to simplify the search by first+last name, and displaying the result in first+last name format also. This should make the resulting name format consistent, and users will see the the same name format as they type.

telusdcinco commented 1 month ago

@jessicahjwu MyTeam Share Profile dropdown reverted to yesterday's version which passed Test and pending Migration to Training. Please do a quick validation in Test, before I move to Training.

telusdcinco commented 1 month ago

Deployed to Training.

telusdcinco commented 1 month ago

Found code difference implemented in #1155, not found in Training and/or Prod. Pushed the missing code to Training.