bcgov / performance

Performance
Apache License 2.0
0 stars 2 forks source link

Reporting relationships did not reflect correctly after supervisor has been selected #1343

Closed jessicahjwu closed 1 month ago

jessicahjwu commented 2 months ago

Nuo Shen, EEID 200364, reports to a double-bunked supervisor Anthony LeFresne. Although they have selected the right supervisor in the platform the reporting relationships did not get reflected correctly and it's impacting their ability to have a conversation:

image.png image.png image.png
telusdcinco commented 2 months ago

@jessicahjwu Codes have been recently modified for #1016 fixes. The dropdown is currently broken. It does not store the selected manager.

@jizhaogit Please review with #1016 changes that may have impacted the dropdown.

telusdcinco commented 2 months ago

Ignore link to #1351 merge request. #1351 closed.

telusdcinco commented 2 months ago

Issue may have been introduced with #857. Issue occurs when the employee selecting the preferred manager has multiple jobs and has a terminated job record 0. The wrong position number is being stored in this case.

Fix will use the position number from the primary job selected (whenever possible) as introduced in #857.

Code change conflict related to #1016 was avoided by using a copy of prod for the development. There is NO dependency on any accessibility change currently pending in Dev/Test.

telusdcinco commented 2 months ago

MIGRATION NOTES:

Code change only.

telusdcinco commented 2 months ago

1016 change currently have impacted the dropdown selection functionality and needs to be fixed. This should be addressed by #1016 before going live.

Currently, this fix can only be tested in Training (which does not have accessibility changes applied.

telusdcinco commented 2 months ago

The #1016 change impacting testing for this fix has been removed, and will be re-applied after this change goes to Prod.

@steffipravasi This can now be tested in Dev/Test.

steffipravasi commented 2 months ago

Test validated and works as expected on test

Screenshot 2024-08-22 at 5.43.24 PM.png Screenshot 2024-08-22 at 5.43.37 PM.png
telusdcinco commented 1 month ago

Deployed to Training.

telusdcinco commented 1 month ago

Deployed to Prod.