search

bcgov / performance

Performance
Apache License 2.0
0 stars 2 forks source link

HR/Sys Admin > Goal Bank > Manage Goals: Business Unit org tree is failing #875

Closed Travis-A-Clark closed 1 year ago

Travis-A-Clark commented 1 year ago

As an HR or Sys Admin, I can't add additional business units to an existing goal. Selecting an org level fails to properly register in the drop down. The tree view "flickers" and the selection is not properly processed.

telusdcinco commented 1 year ago

@Travis-A-Clark

The fix to take care of the Org Tree flicker was pushed to prod Friday. A data fix to delete the invalid Goal Bank Org was also pushed and executed to cleanup the invalid entries created while the flicker issue existed.

Please try adding the missing Orgs in Prod.

Travis-A-Clark commented 1 year ago

@telusdcinco Unfortunately, I am getting an ajax error when I try to edit the business unit audience for an existing goal in the HR Admin Goal Bank. Nothing loads.

image.png

Travis-A-Clark commented 1 year ago

@telusdcinco When I try through Sys Admin, I can edit the business unit audience but it still assigns it to different business units than the ones I selected. See below for example of orgs other than Social Development and Poverty Reduction. Total of 205 business units across gov even though I selected less than 150 all in SDPR.

image.png

telusdcinco commented 1 year ago

The Ajax error is resolved in HR Admin. image.png The org count may need to be fixed for HR Admin.

SysAdmin org selection needs more investigation.

Travis-A-Clark commented 1 year ago

@telusdcinco I can confirm that the problems still exist in Production.

Evelyn Carty is an HR Admin for SDPR. She is responsible for the Service Delivery Division. Her HR Admin access has 152 business units associated with it. When she edits a goal in the goal bank and assigns access to her full division, only 128 business units are reflected. No additions are shown.

The org tree also continues to "flicker" and collapse when adding new business units.

telusdcinco commented 1 year ago

@Travis-A-Clark I have a 1 line code fix for saving HR Goal Bank Org list changes. Please let me know if it can be pushed to prod.

Travis-A-Clark commented 1 year ago

@telusdcinco I like how simple and easy that sounds! :-) Please go ahead and push to prod and restart the pods before you sign off for the day. Thanks!

telusdcinco commented 1 year ago

@Travis-A-Clark Prod App pods have been restarted.

telusdcinco commented 1 year ago

@Travis-A-Clark The fix for duplicate org row issue is ready for deployment to Prod. Please let me know if okay to migrate to prod, and when to restart the pods. Please try to remove the duplicate rows manually.

Travis-A-Clark commented 1 year ago

@telusdcinco As discussed, the fix in Prod has solved the issue with pushing goals to new business units. Users in those new units can now see the appropriate goals. However, from an HR Admin view, we are seeing duplicate rows for business units when pushing out to the organization as per screen shot below. This didn't used to be the case.

image.png

telusdcinco commented 1 year ago

@Travis-A-Clark Fix for duplicate org row issue deployed to prod. Pods restarted. Ready for your validation.