Add a "Completed" Email template and trigger after Requests are Completed. Update "Approved" Email Template

bcgov / platform-services-registry

Platform services OCP project registry

https://registry.developer.gov.bc.ca/

Apache License 2.0

8 stars 13 forks source link

Add a "Completed" Email template and trigger after Requests are Completed. Update "Approved" Email Template #3593

Closed funtigr closed 1 day ago

funtigr commented 2 weeks ago

Description: For now after Approval action user receives an email Request is Approved and Completed though it has to go through Provisioning and may get stuck. We need to add a separate Completed URL and change the wording for Approved URL.

Here’s the updated DoD with an appropriate tone:

Definition of Done (DoD):

[x] The approval email for edit requests excludes completed from the subject line.
[x] The approval email for create, edit, and delete requests includes the paragraph:
Please allow 3-5 minutes for the request to be processed by the backend. If it takes longer, don't hesitate to reach out to us.
- platform-services-registry/app/app/api/private-cloud/requests/[id]/decision/route.ts
[x] A new email template is created to inform the product team when changes of edit request are applied and completed.
- platform-services-registry/app/app/api/private-cloud/provision/[licencePlate]/route.ts
[x] The Mermaid diagram is updated to reflect these changes.

Iryna-Kaplun commented 2 weeks ago

Hey team! Please add your planning poker estimate with Zenhub @Amritpal-Nijjar @funtigr @golebu2020 @junminahn @Kolezhanchik

funtigr commented 1 week ago

After approving the Request, I receive an empty email:
The Approval email that is received after empty one, has a typo (no space). And a call to manage the product, which will be greyed out at the time. I would suggest to change the two passages and merge them like this:

We are pleased to inform you that your request for the product Artem Test Aug 6.2 has been approved on the Private Cloud OpenShift platform. Please allow 3-5 minutes for the request to be processed. If it takes longer, don't hesitate to reach out to us.

The Completed email:
- I suggest we delete term 'approved' from the title of the email and change it to:
  
  Success! Your provisioning request is completed!

And change the first sentence, changing first 'your' to 'the' to escape tautology:

The request for your product on the Private Cloud Openshift platform is complete.

golebu2020 commented 1 week ago

@funtigr please what request were you making? Were you requesting for a new product from scratch or requesting for a quota increase of an existing product?

funtigr commented 5 days ago

@golebu2020 I have made Edit Request for an old product and Create Request for a new one to test out the Create scenario.

funtigr commented 3 days ago

Everything works well except two issues. If you'd like we can start a new ticket for their fix:

For Edit and Create request user receives two Provisioned emails:
In the Approved email we have text about logging in to OpenShift. Though if User logs in to OpenShift before request provisioned, the changes would not have taken place. I think we need to delete the sentence about logging in to the OpenShift console from Approved email:

golebu2020 commented 3 days ago

@funtigr, this behavior seems unusual. We expect to receive the provisioned email only when a new product is created. Specifically, for an Edit Request, we should receive only the approval email, whereas for a Create Request, we should receive both the approval email and the provisioned email. Unfortunately, I no longer have access to the test email to verify this from my end.