bcgov / pm25-caaqs-indicator

R scripts to calculate the Canadian Ambient Air Quality Standards (CAAQS) for fine particulate matter (PM2.5) for B.C. published on Environmental Reporting BC
Apache License 2.0
10 stars 6 forks source link

Update to 2020 #17

Closed steffilazerte closed 2 years ago

steffilazerte commented 2 years ago

Ongoing update of PM2.5 indicator scripts to 2020 data and indicator design.

Main components

Other

Details to-do

Finalizing

steffilazerte commented 2 years ago

Hi @KarHarker @jeromerobles, @j-galloway,

I think I'm ready for a preliminary review! I don't have access to envreportutils.internal, so I can't be sure the print version renders properly, and there are definitely some paragraphs that need to be update. I've also open an issue for questions regarding the new annual figures (#19), if you want to preview the figure without having to compile everything.

Note that I've implemented renv to keep track of packages and versions, and that I'm currently using a dev version of rcaaqs as well as of envreportutils. However, the first step of each of the scripts is to source the 00_setup.R file which should ensure you're using the same packages/versions as me. This is the first time I've collaborated with renv, so let me know if you run into any problems!

Please let me know of anything that needs to change (small or big), or if you have any questions or need me to add any explanations to the code!

KarHarker commented 2 years ago

Thanks, @steffilazerte! I will review early next week