Create final reports in a new script

bcgov / post-secondary-supply-model

A repository to house the code base for Post-Secondary Supply Model (PSSM)

Apache License 2.0

0 stars 0 forks source link

Create final reports in a new script #43

Closed lindsay-fredrick closed 3 weeks ago

lindsay-fredrick commented 1 month ago

Reproduce the graduation projections counts
Reproduce the occupation projections counts
Format into similar style as previously done

lindsay-fredrick commented 1 month ago

Noting - with this process moving into a new script, we will want to remove some of the process from the 07 script. However I didn't want to modify that one right away as I know Amelia is still using it. The main focus here is the new 08 script.

aclowery commented 4 weeks ago

Just an additional note, we could use this script for the public release version as well?

lindsay-fredrick commented 4 weeks ago

I think we use a copy of the script with the required modifications for public release for sure - that can be done in a new PR however! (less important right now I think?) I'll add it if you think it would be a good addition to this PR though.

Also need to remove the associated sql from 07 - do you want me to do that here?

lindsay-fredrick commented 3 weeks ago

FYI on latest commit:

that commit adds the code required to make the public release version of the data
it also moves all the excel stuff into a function so I didn't have to repeat myself

However I weas getting weird behaviour when I run it (in that when I opened up the excel file, the occupation projections had a MASSIVE number of rows for some reason, and I have no clue why. If someone could look at it/run it and see if it happens for them as well that would be great).

Otherwise, I'm hoping this is the last update to the 08 file. Noting that I did compare and found that the numbers matched with the reference numbers Amelia pulled using the old sql queries.

lindsay-fredrick commented 3 weeks ago

@aclowery are you happy with the last set of changes? I'm willing to merge this into refactor-nocs if you approve :)

aclowery commented 3 weeks ago

@lindsay-fredrick I am happy with the script (confirmed by running last times through a modified version) and would go ahead and merge. Thanks!