bcgov / ppr-deprecated

deprecated-Personal Property Registry
Apache License 2.0
2 stars 10 forks source link

Enhance use of registration "life" in the API #855

Closed jguertin closed 4 years ago

jguertin commented 4 years ago

Rename financing statement "years" to "lifeYears" in the API interface. Update the spec to include infinite life with a "lifeInfinite" property.

codecov[bot] commented 4 years ago

Codecov Report

Merging #855 into master will decrease coverage by 0.03%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #855      +/-   ##
==========================================
- Coverage   93.72%   93.68%   -0.04%     
==========================================
  Files          59       59              
  Lines        1338     1331       -7     
  Branches      117      114       -3     
==========================================
- Hits         1254     1247       -7     
  Misses         82       82              
  Partials        2        2
Flag Coverage Δ
#python_unittests 97.17% <100%> (-0.01%) :arrow_down:
Impacted Files Coverage Δ
ppr-api/src/endpoints/financing_statement.py 100% <ø> (ø) :arrow_up:
...c/financing-statement/financing-statement-model.ts 100% <ø> (ø) :arrow_up:
...i/src/repository/financing_statement_repository.py 100% <100%> (ø) :arrow_up:
ppr-api/src/schemas/financing_statement.py 100% <100%> (ø) :arrow_up:
...-ui/src/financing-statement/FinancingStatement.vue 100% <0%> (ø) :arrow_up:
ppr-ui/src/base-party/BaseParty.vue 100% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9c2ad9d...3f0172e. Read the comment docs.

sonarcloud[bot] commented 4 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

jguertin commented 4 years ago

The issue talks about lifeInfinite. Where is this?

This is not a complete implementation, but just the change to the API contract. with existing behaviour.