gh2os commented 4 years ago

First past at adding some validation to the Party Schema:

personName is alphabetical other than hyphen ( - ) or apostrophe ( ' )
businessName is alphanumeric plus allows the following special characters: & ' : , $ - ( ) % . + " " ; /
Party cannot have businessName and personName

Also added basic tests for IndividualName and Address classes

codecov[bot] commented 4 years ago

Codecov Report

Merging #859 into master will increase coverage by 0.04%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #859      +/-   ##
==========================================
+ Coverage   93.71%   93.75%   +0.04%     
==========================================
  Files          59       59              
  Lines        1336     1345       +9     
  Branches      116      117       +1     
==========================================
+ Hits         1252     1261       +9     
  Misses         82       82              
  Partials        2        2

Flag	Coverage Δ
#python_unittests	`97.2% <100%> (+0.03%)`	:arrow_up:

Impacted Files	Coverage Δ
ppr-api/src/schemas/party.py	`100% <100%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5d4aea4...932d7ff. Read the comment docs.