bcgov / ppr-deprecated

deprecated-Personal Property Registry
Apache License 2.0
2 stars 10 forks source link

Upgrade to fastapi 0.52.0 #862

Closed jguertin closed 4 years ago

jguertin commented 4 years ago

The 0.42.0 version of fastapi used pydantic 0.32.0 and we've been running against some validation limitations which made it difficult to work with.

Fastapi 0.52.0 uses pydantic 1.4 which has significant improvements. In particular:

Unfortunately, you'll note some additional pylint checks being disabled. pylint running on github actions has had issues recognizing the inner workings of pydantic. I'm not clear why, but this should eventually be handled as part of #288.

sonarcloud[bot] commented 4 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication