bryan-gilbert commented 4 years ago

Add a confirmation dialog component. When Repairer's Lien elements are added will need to toggle their display based on selected type. May wish to only show the confirm change dialog after user has actually made a change.

codecov[bot] commented 4 years ago

Codecov Report

Merging #871 into master will decrease coverage by 0.58%. The diff coverage is 71.42%.

@@            Coverage Diff             @@
##           master     #871      +/-   ##
==========================================
- Coverage   93.78%   93.19%   -0.59%     
==========================================
  Files          59       61       +2     
  Lines        1352     1382      +30     
  Branches      118      119       +1     
==========================================
+ Hits         1268     1288      +20     
- Misses         82       92      +10     
  Partials        2        2

Flag	Coverage Δ
#python_unittests	`97.19% <ø> (ø)`	:arrow_up:

Impacted Files	Coverage Δ
...-ui/src/financing-statement/FinancingStatement.vue	`100% <100%> (ø)`	:arrow_up:
ppr-ui/src/components/DialogConfirm.vue	`60% <60%> (ø)`
ppr-ui/src/financing-statement/TypeComponent.vue	`75% <75%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bb2b960...e3afb96. Read the comment docs.

sonarcloud[bot] commented 4 years ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

No Coverage information
0.0% Duplication

bcgov / ppr-deprecated

Financing Statement select and change type. #871

Codecov Report