bcgov / ppr-deprecated

deprecated-Personal Property Registry
Apache License 2.0
2 stars 10 forks source link

Correct life storage in the database #881

Closed jguertin closed 4 years ago

jguertin commented 4 years ago

Correct life storage to have cumulative life stored on the financing statement and individual events (base registration and renewals) stored on events.

codecov[bot] commented 4 years ago

Codecov Report

Merging #881 into master will increase coverage by 0.05%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #881      +/-   ##
==========================================
+ Coverage   93.82%   93.88%   +0.05%     
==========================================
  Files          59       59              
  Lines        1361     1373      +12     
  Branches      122      125       +3     
==========================================
+ Hits         1277     1289      +12     
  Misses         82       82              
  Partials        2        2
Flag Coverage Δ
#python_unittests 97.28% <100%> (+0.05%) :arrow_up:
Impacted Files Coverage Δ
ppr-api/src/endpoints/search.py 100% <100%> (ø) :arrow_up:
...i/src/repository/financing_statement_repository.py 100% <100%> (ø) :arrow_up:
ppr-api/src/models/financing_statement.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4eac19b...a191094. Read the comment docs.

sonarcloud[bot] commented 4 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication