search

bcgov / ppr-deprecated

deprecated-Personal Property Registry
Apache License 2.0
2 stars 10 forks source link

Fixed bug where undefined used in JSON #911

Closed WalterMoar closed 4 years ago

WalterMoar commented 4 years ago

The TypeScript value undefined was erroneously being used in JSON. Fixed this for the person name, as it was very visible for missing middle names. It likely needs to be done elsewhere, TBD.

sonarcloud[bot] commented 4 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

WalterMoar commented 4 years ago

@jguertin That might be the special sauce needed to do it - define as null in the interface and use TypeScript's null/undefined "sorta equivalence" to bridge the gap.

(errr, nevermind, I turned on strict typechecking and that won't fly. Oh well).