search

bcgov / quickstart-openshift

QuickStart template targeted for OpenShift.
https://quickstart-openshift-test-frontend.apps.silver.devops.gov.bc.ca/
Apache License 2.0
29 stars 4 forks source link

Need to look at how to avoid ZAP rate limiting issues #1941

Closed mishraomp closed 2 months ago

mishraomp commented 3 months ago

Thanks to @afwilcox for reporting. https://github.com/bcgov/nr-compliance-enforcement/actions/runs/8806409114/job/24171796325

Error: You have exceeded a secondary rate limit. Please wait a few minutes before you try again. If you reach out to GitHub Support for help, please include the request ID E0A8:2C1F3A:1299426:1E4A642:662816D6. - https://docs.github.com/free-pro-team@latest/rest/overview/rate-limits-for-the-rest-api#about-secondary-rate-limits

DerekRoberts commented 3 months ago

@mishraomp I'm unfortunately not sure we can do anything about this. It's a ZAP bug that doesn't appear to be recurring regularly. Should we just keep notes and try to predict fails?

mishraomp commented 3 months ago

@mishraomp I'm unfortunately not sure we can do anything about this. It's a ZAP bug that doesn't appear to be recurring regularly. Should we just keep notes and try to predict fails?

may be it happens with repository where matrix strategy is used and multiple zap scans for different components are running in parallel, just assumption based on the finding of C&E repo, since that's the only one with 3 components having routes exposed and pen test enabled.

DerekRoberts commented 3 months ago

ZAP isn't wonderfully configurable, but we could use sequential instead of parallel runs. Any idea how often the problem happens?

DerekRoberts commented 3 months ago

Poop. This error is turning up elsewhere. https://github.com/bcgov/quickstart-openshift/actions/runs/8785653950/job/24106670587

DerekRoberts commented 2 months ago

I think this has been resolved upstream. Closing.