bcgov / quickstart-openshift

QuickStart template targeted for OpenShift.
https://quickstart-openshift-test-frontend.apps.silver.devops.gov.bc.ca/
Apache License 2.0
28 stars 4 forks source link

feat: using ingress with derived hostname <releasename>.<domain>/<com… #1995

Closed cberg-aot closed 1 month ago

cberg-aot commented 1 month ago

…ponentname>

Description

Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

cberg-aot commented 1 month ago

@DerekRoberts can you help debug why this is not loading frontend? I experimented with onroute and had a similar refactor working

DerekRoberts commented 1 month ago

@cberg-aot Very nice! I'm off until Monday, but think this is close. Thanks for the improvement! :)

mishraomp commented 1 month ago

why do we need this refactor? I don't see any value TBH @cberg-aot @DerekRoberts

Also we are no longer using helm-service, as it was very much complex and decided to keep everything to the repo itself, sometimes redundancy is good :)

DerekRoberts commented 1 month ago

@mishraomp We'd like to go pure k8s, favoring ingress over routes.

mishraomp commented 1 month ago

@mishraomp We'd like to go pure k8s, favoring ingress over routes.

which we already do, https://github.com/bcgov/quickstart-openshift/blob/main/charts/app/templates/frontend/templates/ingress.yaml

this is the release which is when we went K8S native https://github.com/bcgov/quickstart-openshift/releases/tag/V0.50.0