search

bcgov / rcaaqs

An R package to facilitate the calculation of air quality metrics according to Canadian Ambient Air Quality Standards
Apache License 2.0
16 stars 5 forks source link

Be consistent with argument for data #37

Closed steffilazerte closed 5 years ago

steffilazerte commented 6 years ago

Various functions use different argument names for the incoming dataset. For example:

Suggest we pick one to be consistent (df is probably the best)

boshek commented 6 years ago

data is more standard no? I think about lm(), plot() or ggplot2()

steffilazerte commented 6 years ago

True, I was thinking along the lines that data() is an R base function (well utils), and I've heard the argument that it's best to avoid it. But perhaps that refers to data in scripts as opposed to in functions.

Other than that I quite like data as an argument

ateucher commented 6 years ago

I think data works as an argument name. Thanks both!