bcgov / rcaaqs

An R package to facilitate the calculation of air quality metrics according to Canadian Ambient Air Quality Standards
Apache License 2.0
16 stars 5 forks source link

rcaaqs:::quantile2 returns the maximum value in x when probs=1 and type="caaqs" #64

Closed stephhazlitt closed 11 months ago

stephhazlitt commented 12 months ago

Tackles #62 but uses ifelse so that the fxn is still vectorized.

Note, there are 1176 PASSING & 9 FAILING tests on main(and the failures are unrelated to this issue). This PR adds an additional test, and so there are 1177 PASSING and still the 9 FAILING. I'll open a new issue re: addressing the test failures.