bcgov / reggie

This is a tool to register for and invite user to bcgov self-serve applications through keyCloak SSO
Apache License 2.0
2 stars 0 forks source link

Fix: show logs #33

Closed ShellyXueHan closed 5 years ago

ShellyXueHan commented 5 years ago

console log email invitation sent, as temporary solution for keeping track.

repo-mountie[bot] commented 5 years ago

@ShellyXueHan When a pull request (PR) is over the 200-400 line range (of change) the ability of the reviewer to effectively detect issues quickly diminishes. Your PR is over the preferred length of 250 lines set for this repo. While this cannot always be avoided, please be mindful of the reviewer's time by organizing your work into smaller, more manageable PRs.

Here are a few thoughtful articles on what a good PR should look like:

The Anatomy of a Perfect Pull Request

Optimal Pull Request Size

Best Practices for Code Review

Pro Tip