search

bcgov / rems

An R package to access data from British Columbia's Environmental Monitoring System
Apache License 2.0
19 stars 5 forks source link

`download_historic_data()` seems to trigger Deprecation notice for authentication via URL query parameters #49

Closed joethorley closed 4 years ago

joethorley commented 4 years ago

It may be coincidence but I just ran download_historic_data() and got the following email from GitHub

Hi @joethorley,

On November 6th, 2020 at 16:49 (UTC) your personal access token (R:GITHUB_PAT) using libcurl/7.64.1 r-curl/4.3 httr/1.4.2 was used as part of a query parameter to access an endpoint through the GitHub API:

https://api.github.com/repositories/63990524/releases/latest

Please use the Authorization HTTP header instead, as using the `access_token` query parameter is deprecated. If this token is being used by an app you don't have control over, be aware that it may stop working as a result of this deprecation.

Depending on your API usage, we'll be sending you this email reminder on a monthly basis for each token and User-Agent used in API calls made on your behalf.
Just one URL that was accessed with a token and User-Agent combination will be listed in the email reminder, not all.

Visit https://developer.github.com/changes/2020-02-10-deprecating-auth-through-query-param for more information about suggested workarounds and removal dates.

Thanks,
The GitHub Team
ateucher commented 4 years ago

Thanks @joethorley I'll fix this - I've had other packages where this has happened.