search

bcgov / rems

An R package to access data from British Columbia's Environmental Monitoring System
Apache License 2.0
19 stars 5 forks source link

Fix regex errors and multiple files with 4yr data #54

Closed steffilazerte closed 3 years ago

steffilazerte commented 3 years ago

This pull request fixes the regex errors coming from the addition of out.txt in the data index (#53) as well as picks zip files if both zip and csv are returned.

ateucher commented 3 years ago

Thanks so much for this @steffilazerte - I'm actually in the process of fixing this and related issues in #52, but your code for creating the metadata dataframe is much nicer than mine, so I think I'll take this, and merge it into the duckdb branch!

steffilazerte commented 3 years ago

Hahah I thought I checked out the issues, but clearly didn't check out open pull requests. Will do that next time :wink:

ateucher commented 3 years ago

No problem - still much appreciated!