search

bcgov / rems

An R package to access data from British Columbia's Environmental Monitoring System
Apache License 2.0
19 stars 5 forks source link

Convert mdl units #57

Closed ateucher closed 3 years ago

ateucher commented 3 years ago

Initial work to address https://github.com/bcgov/wqbc/issues/158. Unfortunately it's not very fast (~11 seconds for 5000 rows) due to having to loop over the rows, since {units} isn't vectorized over different units.

ateucher commented 3 years ago

@joethorley I think this is a pretty good solution, one TODO remaining.

ateucher commented 3 years ago

@joethorley @JessicaPenno @KarHarker @j-krogh I am ready to merge this - please have a look if you'd like. See the README for a brief demo of its usage.

joethorley commented 3 years ago

That is very elegant - hats off!

ateucher commented 3 years ago

Thanks Joe!

JessicaPenno commented 3 years ago

Awesome Andy!! I assume that I do not need to review the units table anymore, I have not got to that yet

@joethorley how do we get this into ShinyREMs?

ateucher commented 3 years ago

Thanks @JessicaPenno - no you don't need to review it now :)

joethorley commented 3 years ago

@JessicaPenno - I think it needs to be added to the wqbc functions and then shinyrems will just need tweaking internally to make sure the data goes through this step.