search

bcgov / repomountie

The repo mountie is a bot to help mange cultural policies relevant to our repos
Apache License 2.0
7 stars 16 forks source link

The bot should detect reference style links for status badge usage #144

Open jleach opened 3 years ago

jleach commented 3 years ago

Describe the issue

The bot does not correctly detect reference style links used for status badges:

[![Lifecycle][lifecycle-shield]](https://github.com/bcgov/repomountie/blob/master/doc/lifecycle-badges.md)
[lifecycle-shield]: https://img.shields.io/badge/Lifecycle-Stable-97ca00?style=for-the-badge

Additional context

Example repository: bcgov/containerization-and-cloud-economic-model#22

Definition of done

The bot correctly detects reference style links in a projects MD file and deals with them appropriately.

DerekRoberts commented 3 years ago

@jleach Reference-style links removed after latest false positive. Path of least resistance.

https://github.com/bcgov/containerization-and-cloud-economic-model/issues/26 https://github.com/bcgov/containerization-and-cloud-economic-model/pull/27

stephhazlitt commented 3 years ago

I am not sure if this is related, however the bot opened a Add project lifecycle badge Issue when there is an existing lifestyle badge in the README https://github.com/bcgov/imit-procurement-data-analysis/issues/8

DerekRoberts commented 3 years ago

@stephhazlitt The bot is likely caught up on formatting. It can't hurt to try this team on Rocket.Chat's #devops-how-to channel.

E.g. https://img.shields.io/badge/Lifecycle-Dormant-%23ff7f2a vs https://img.shields.io/badge/Lifecycle-Dormant