Repomountie is recreating a "missing topic" issue after topic was created

bcgov / repomountie

The repo mountie is a bot to help mange cultural policies relevant to our repos

Apache License 2.0

7 stars 16 forks source link

Repomountie is recreating a "missing topic" issue after topic was created #84

Closed matthieu-foucault closed 4 years ago

matthieu-foucault commented 4 years ago

Following the request from repomountie to add the missing topic (https://github.com/bcgov/cas-ggircs-ciip-2018-schema/issues/22), I added it and closed the issue. However the same issue was recreated shortly after (https://github.com/bcgov/cas-ggircs-ciip-2018-schema/issues/23)

jleach commented 4 years ago

Investigating.

jleach commented 4 years ago

While it did create a duplicate issue, I haven't been able to reproduce this yet. Seems isolated as I'm not seeing duplicates across other repos. Handy GitHub search org:bcgov type:issue "Add missing topics" created:2020-04-17

Time	Comment
04/17: 10:33a	Added all short codes 151ecf9
04/17 12:28p	Create issue 22
04/17 3:19p	Bot 5 deployed
04/17 3:27p	Commented and closed 22
04/17 4:30p	Created issue 23

matthieu-foucault commented 4 years ago

It happened with https://github.com/bcgov/cas-ciip-portal/issues/550 and https://github.com/bcgov/cas-ciip-portal/issues/551 too. I closed 551 a couple of hours ago and it didn't create another issue, so I guess I can't reproduce it either

jleach commented 4 years ago

I'm using this query to go through all the repos that have previously closed this issue to see if the bot is creating duplicates. I want to see how widespread it is to see if the feature needs to be disabled.

80 done so far, dupes in: bcgov/cas-ciip-portal bcgov/cas-ggircs-ciip-2018-schema tire-recyceling-indicator

WadeBarnes commented 4 years ago

I've seen this issue a couple times. Most recently yesterday, with;

https://github.com/bcgov/iiwbook/issues/52 - Topic (citz) was added, issue was closed.
https://github.com/bcgov/iiwbook/issues/54 - A little while later repo-mountie added another issue.

jleach commented 4 years ago

@WadeBarnes Thx for reporting. I saw it also in another repo so I disabled the feature late yesterday and I am refactoring the code so it only runs this logic when a repo is first created. Should be done this AM.