search

bcgov / rocketchat

The Platform Services Rocket.Chat communication service
Apache License 2.0
1 stars 0 forks source link

Migration to Argo CD #17

Closed IanKWatts closed 2 years ago

jleach commented 2 years ago

@IanKWatts Is devops/base/sa/vault.yaml needed still? I though @ShellyXueHan mentioned the SA is no longer required because CCM creates them by default now.

IanKWatts commented 2 years ago

@IanKWatts Is devops/base/sa/vault.yaml needed still? I though @ShellyXueHan mentioned the SA is no longer required because CCM creates them by default now.

@jleach I'm not sure if that service account is still required - or I have forgotten, if Shelly told me. It still exists in each of the namespaces.

This PR is not ready to merge yet, but Shelly and I will migrate Prod to Argo CD this week, and I wanted to review the changes and address any remaining issues first. Dev and Test have already been migrated to Argo CD.

jleach commented 2 years ago

@IanKWatts Might want to convert it to be a Draft PR then. Looks like @ShellyXueHan has a PR #16 open to remove the SA.

ShellyXueHan commented 2 years ago

Vault operator is managing those services accounts now, so we don't recreate them here anymore. I just comment out but haven't deleted them yet, more of keeping them as a backup for now.