bcgov / sbc-auth

ServiceBC common authentication and authorization services
Apache License 2.0
9 stars 67 forks source link

23519 - Change Staff Review Dashboard Continuation Table #3072

Closed ArwenQin closed 1 month ago

ArwenQin commented 1 month ago

Issue #: https://github.com/bcgov/entity/issues/23519

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).

severinbeauvais commented 1 month ago

/gcbrun

bcregistry-sre commented 1 month ago

Temporary Url for review: https://bcregistry-account-dev--pr-3072-op59dhj8.web.app

ArwenQin commented 1 month ago

@severinbeauvais Just confirmed with Jacqueline, we will keep the more action button for now.

vysakh-menon-aot commented 1 month ago

@severinbeauvais Just confirmed with Jacqueline, we will keep the more action button for now.

Did you get confirmation on officeEmail?

ArwenQin commented 1 month ago

@severinbeauvais Just confirmed with Jacqueline, we will keep the more action button for now.

Did you get confirmation on officeEmail?

Not yet, seems still pending. @severinbeauvais Did you get updates?

severinbeauvais commented 1 month ago

@severinbeauvais Just confirmed with Jacqueline, we will keep the more action button for now.

Did you get confirmation on officeEmail?

Not yet, seems still pending. @severinbeauvais Did you get updates?

What's the question we need answered? I will ask her directly.

ArwenQin commented 1 month ago

@severinbeauvais Just confirmed with Jacqueline, we will keep the more action button for now.

Did you get confirmation on officeEmail?

Not yet, seems still pending. @severinbeauvais Did you get updates?

What's the question we need answered? I will ask her directly.

The changes on registered office email column, changing from completing party to the email address. Are the new designs confirmed?

severinbeauvais commented 1 month ago

What's the question we need answered? I will ask her directly.

The changes on registered office email column, changing from completing party to the email address. Are the new designs confirmed?

In the table, the contact information email column should be labelled "Registered Office". There is a policy reason for this.

The review page has also been updated (but that's another ticket).

ArwenQin commented 1 month ago

So I will update line 388 the value to be officeEmail; just for everywhere, update it to be officeEmail

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud