bcgov / sbc-common-components

Apache License 2.0
0 stars 41 forks source link

Added flex class so header height is maintained #303

Closed severinbeauvais closed 2 years ago

severinbeauvais commented 2 years ago

Issue #: None

Description of changes:

While updating Filings UI and Create UI to Vue 2.7 (and related dependencies), I noticed that the SBC Header height was not being maintained correctly (ie, same as height of inner elements):

image

A temporary fix was to set the outer div to display=flex in Filings UI and Create UI, but this PR is a permanent fix.

This code does not need to be released right away, so I'm not updating the app version or planning to publish this fix -- it can go out with a future change to this library.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).