bcgov / sbc-pay

ServiceBC common payment services for one-time and long-enagement partners
Apache License 2.0
7 stars 39 forks source link

20088 - Unlock associated accounts when paid with exact amount #1561

Closed rodrigo-barraza closed 3 months ago

rodrigo-barraza commented 3 months ago

Issue #: https://github.com/bcgov/entity/issues/20088

Description of changes: Unlocking overdue BCROS account when paid with exact amount

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.30%. Comparing base (79924ce) to head (66dc406). Report is 172 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1561 +/- ## ========================================== + Coverage 91.45% 93.30% +1.84% ========================================== Files 186 146 -40 Lines 11319 9777 -1542 ========================================== - Hits 10352 9122 -1230 + Misses 967 655 -312 ``` | [Flag](https://app.codecov.io/gh/bcgov/sbc-pay/pull/1561/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | Coverage Δ | | |---|---|---| | [bcolapi](https://app.codecov.io/gh/bcgov/sbc-pay/pull/1561/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | `?` | | | [eventlistenerqueue](https://app.codecov.io/gh/bcgov/sbc-pay/pull/1561/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | `?` | | | [payapi](https://app.codecov.io/gh/bcgov/sbc-pay/pull/1561/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | `93.30% <100.00%> (-0.44%)` | :arrow_down: | | [paymentjobs](https://app.codecov.io/gh/bcgov/sbc-pay/pull/1561/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | `?` | | | [paymentreconciliationsqueue](https://app.codecov.io/gh/bcgov/sbc-pay/pull/1561/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | `?` | | | [reportapi](https://app.codecov.io/gh/bcgov/sbc-pay/pull/1561/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/bcgov/sbc-pay/pull/1561?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | Coverage Δ | | |---|---|---| | [pay-api/src/pay\_api/services/\_\_init\_\_.py](https://app.codecov.io/gh/bcgov/sbc-pay/pull/1561?src=pr&el=tree&filepath=pay-api%2Fsrc%2Fpay_api%2Fservices%2F__init__.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-cGF5LWFwaS9zcmMvcGF5X2FwaS9zZXJ2aWNlcy9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | | ... and [194 files with indirect coverage changes](https://app.codecov.io/gh/bcgov/sbc-pay/pull/1561/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov)