bcgov / sbc-pay

ServiceBC common payment services for one-time and long-enagement partners
Apache License 2.0
7 stars 39 forks source link

20719- Interim Statements Settings Fix #1584

Closed ochiu closed 2 months ago

ochiu commented 2 months ago

Issue #: https://github.com/bcgov/entity/issues/20719

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 72.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 82.62%. Comparing base (79924ce) to head (c5c54cf). Report is 189 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1584 +/- ## ========================================== - Coverage 91.45% 82.62% -8.84% ========================================== Files 186 23 -163 Lines 11319 1974 -9345 ========================================== - Hits 10352 1631 -8721 + Misses 967 343 -624 ``` | [Flag](https://app.codecov.io/gh/bcgov/sbc-pay/pull/1584/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | Coverage Δ | | |---|---|---| | [bcolapi](https://app.codecov.io/gh/bcgov/sbc-pay/pull/1584/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | `?` | | | [eventlistenerqueue](https://app.codecov.io/gh/bcgov/sbc-pay/pull/1584/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | `?` | | | [payapi](https://app.codecov.io/gh/bcgov/sbc-pay/pull/1584/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | `?` | | | [paymentjobs](https://app.codecov.io/gh/bcgov/sbc-pay/pull/1584/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | `82.62% <72.00%> (+2.40%)` | :arrow_up: | | [paymentreconciliationsqueue](https://app.codecov.io/gh/bcgov/sbc-pay/pull/1584/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | `?` | | | [reportapi](https://app.codecov.io/gh/bcgov/sbc-pay/pull/1584/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/bcgov/sbc-pay/pull/1584?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov) | Coverage Δ | | |---|---|---| | [jobs/payment-jobs/tasks/statement\_task.py](https://app.codecov.io/gh/bcgov/sbc-pay/pull/1584?src=pr&el=tree&filepath=jobs%2Fpayment-jobs%2Ftasks%2Fstatement_task.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov#diff-am9icy9wYXltZW50LWpvYnMvdGFza3Mvc3RhdGVtZW50X3Rhc2sucHk=) | `87.73% <72.00%> (+7.30%)` | :arrow_up: | ... and [166 files with indirect coverage changes](https://app.codecov.io/gh/bcgov/sbc-pay/pull/1584/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov)